[PATCH] [X86] Add missing memory variants to AVX false dependency breaking
Simon Pilgrim
llvm-dev at redking.me.uk
Fri Dec 26 03:19:36 PST 2014
Minor proposed changes (sqrtsd and missing tests).
================
Comment at: lib/Target/X86/X86InstrInfo.cpp:4593
@@ -4574,3 +4592,3 @@
case X86::VSQRTSSr:
-
+ case X86::VSQRTSSm:
// AVX-512
----------------
Please can you add the VSQRTSD versions?
================
Comment at: test/CodeGen/X86/break-false-dep.ll:4
@@ -3,2 +3,3 @@
+; RUN: llc < %s -mtriple=x86_64-win32 -mattr=+avx -mcpu=corei7-avx | FileCheck %s --check-prefix=AVX
define double @t1(float* nocapture %x) nounwind readonly ssp {
----------------
For thoroughness would it not make sense to ensure all the relevant tests check both SSE and AVX passes?
http://reviews.llvm.org/D6780
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list