[PATCH] [Tablegen] Fix alias instruction printer mangling opcodes with optional suffixes.
hfinkel at anl.gov
hfinkel at anl.gov
Tue Dec 23 15:27:15 PST 2014
Can you please upload this patch with full context? For instructions, see:
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
================
Comment at: utils/TableGen/AsmWriterEmitter.cpp:1029
@@ -1026,2 +1028,3 @@
O << " printOperand(MI, unsigned(AsmString[I++]) - 1, OS);\n";
- O << " } else {\n";
+ O << " } else if (NeedOpcodeSep &&\n";
+ O << " (AsmString[I] == ' ' || AsmString[I] == '\t')) {\n";
----------------
So the general idea here is that we always eat the first ' ' or '\t' and replace it with a '\t'. All other whitespace (including that in between operands) passes through as provided. Is that right?
http://reviews.llvm.org/D6530
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list