[PATCH] Moar string interceptors: strstr, strcasestr, strcspn, strpbrk

[Maria Guseva]

================
Comment at: lib/asan/asan_rtl.cc:130
@@ +129,3 @@
+  // The replace_str=false overwrites other replace_str* flags
+  if (!f->replace_str) {
+    cf->replace_strstr = false;
----------------
kcc wrote:
> Is this necessary?
> Such things are sometimes unavoidable, but they complicate the code, the understanding and the documentation. 
> I'd rather prefer users to add more flags... 
> 
If we remove it there will be still some uncertainty in documentation. From user's point of view it's not clear which interceptors replace_str controls and which not. I supposed it should control all of them and overwrite other replace_str* flags in non default case.  Otherwise I think it must be specified that replace_str controls only some subset of string interceptiors while for rest there are custom flags. Shouldn't we to fix the replace_str description for that case?

http://reviews.llvm.org/D6056

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/