[PATCH] [dsymutil] Implement the BinaryHolder object and gain archive support.

[Alexey Samsonov]

LGTM, with comments below addressed.


================
Comment at: tools/dsymutil/BinaryHolder.cpp:58
@@ +57,3 @@
+  StringRef CurArchiveName = CurrentArchive->getFileName();
+  if (Filename.size() <= CurArchiveName.size() ||
+      !Filename.startswith(CurArchiveName) ||
----------------
will this work?
  Filename.startswith(Twine(CurArchiveName, "(").str())

================
Comment at: tools/dsymutil/BinaryHolder.cpp:106
@@ +105,3 @@
+      object::ObjectFile::createObjectFile(*ErrOrMemBufferRef);
+  if (auto Err = ErrOrMemBufferRef.getError())
+    return Err;
----------------
s/ErrOrMemBufferRef/ErrOrObjectFile

================
Comment at: tools/dsymutil/BinaryHolder.h:75
@@ +74,3 @@
+  /// the BinaryHolder.
+  ErrorOr<const object::ObjectFile &> GetObjectFile(StringRef Filename);
+
----------------
Does it need to be a public method?

http://reviews.llvm.org/D6690

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/