[compiler-rt] r224519 - tsan: fix deadlock reporting

Kostya Serebryany kcc at google.com
Fri Dec 19 11:43:04 PST 2014


nice, thanks!

On Thu, Dec 18, 2014 at 6:05 AM, Dmitry Vyukov <dvyukov at google.com> wrote:
>
> Author: dvyukov
> Date: Thu Dec 18 08:05:34 2014
> New Revision: 224519
>
> URL: http://llvm.org/viewvc/llvm-project?rev=224519&view=rev
> Log:
> tsan: fix deadlock reporting
>
> currently deadlock detector reports effectively random stacks in report
> after flush
> because it looks at old edges with wrong stacks
>
>
> Modified:
>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector.h
>
> Modified:
> compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector.h
> URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector.h?rev=224519&r1=224518&r2=224519&view=diff
>
> ==============================================================================
> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector.h
> (original)
> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector.h
> Thu Dec 18 08:05:34 2014
> @@ -178,6 +178,7 @@ class DeadlockDetector {
>      recycled_nodes_.clear();
>      available_nodes_.setAll();
>      g_.clear();
> +    n_edges_ = 0;
>      return getAvailableNode(data);
>    }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141219/f71b65e5/attachment.html>


More information about the llvm-commits mailing list