[Patches][RFC] What to do about bitcode streaming.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Dec 19 06:41:29 PST 2014


> I CC'ed llvmdev to put a few more eyes on the "what's the right
> direction?" question.
>
> IMO these both look like huge improvements.  The streaming interface was
> the strangest part of the bitcode reader when I was trying to figure out
> how it all fit together for the use-list-order work.
>
> Personally I favour the "just delete it" path, but maybe there's
> something I'm missing, and the other patch looks great too.
>
> I didn't read carefully yet (although I noticed two quirks in the first
> patch that I've pointed out below) -- I'll have a closer look once
> you've decided on a direction.

Thanks. Looks like the clang-format I had installed was a bit too old.
I have also rebased and removed the debug output.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-data-streamer.patch
Type: text/x-patch
Size: 39216 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141219/ed244e66/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: known-size.patch
Type: text/x-patch
Size: 40048 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141219/ed244e66/attachment-0001.bin>


More information about the llvm-commits mailing list