[PATCH] [macho] Minor install_name fixes

Jean-Daniel Dupas mailing at xenonium.com
Fri Dec 19 04:00:26 PST 2014


Hi kledzik,

Fix the binary file reader to properly read dyld version info.
Update the install_name test case to properly test the binary reader. We can't use '-print_atoms' as the output format is 'native' yaml and it does not contains the dyld current and compatibility versions. 

Also change the timestamp value of LD_ID_DYLD to match the one generated by ld64.
The dynamic linker (dyld) used to expects different values for timestamp in LD_ID_DYLD and LD_LOAD_DYLD for prebound images. While prebinding is deprecated, we should probably keep it safe and match ld64.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D6736

Files:
  lib/ReaderWriter/MachO/MachONormalizedFileBinaryReader.cpp
  lib/ReaderWriter/MachO/MachONormalizedFileBinaryWriter.cpp
  test/mach-o/dylib-install-names.yaml

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6736.17487.patch
Type: text/x-patch
Size: 5072 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141219/404b92a4/attachment.bin>


More information about the llvm-commits mailing list