[PATCH] [zorg] Add options allowing MSVC builds with Clang Cmake Build Factory.

[Rick Foos]

================
Comment at: zorg/buildbot/builders/ClangBuilder.py:548
@@ +547,3 @@
+    ############# CLEANING
+    doCleanIf = lambda step: step.build.getProperty("force_build_clean") or clean
+    f.addStep(RemoveDirectory(name='clean stage 1',
----------------
rfoos wrote:
> gkistanova wrote:
> > May I suggest defining the "clean" arg as a property and then do a unified check if we need to clean.
> > The build property will overwrite the builder or a slave one.
> > 
> > At least this is what I'm going to do as a common approach for all builders.
> > 
> It looked like the Force Build form 'clean before building' checkbox was setting a property named force_build_clean. 
> 
> If force_build_clean is a standard buildbot property, I thought we might want to incorporate it.
> 
>     doStepIf=Property('clean')
> 
force_build_clean is NOT a standard property. 

I found it on a different hexbot and it turned out to be a property set up in ForceScheduler,

Using clean as a property will be fine.

Below is how a checkbox can be made to set a clean property clean on the ForceScheduler form if you want.

    c['schedulers'].append(ForceScheduler(
       ...
        # A completely customized property list.  The name of the
        # property is the name of the parameter
        properties=[
                BooleanParameter(name="force_build_clean",
                                      label="force a make clean",
                                      default=False),
        ]
    ...
    )

http://reviews.llvm.org/D5588

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/