[compiler-rt] r224507 - tsan: disable flaky debug check

Dmitry Vyukov dvyukov at google.com
Thu Dec 18 02:17:01 PST 2014


Author: dvyukov
Date: Thu Dec 18 04:17:01 2014
New Revision: 224507

URL: http://llvm.org/viewvc/llvm-project?rev=224507&view=rev
Log:
tsan: disable flaky debug check

see the comment for details


Modified:
    compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc

Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc?rev=224507&r1=224506&r2=224507&view=diff
==============================================================================
--- compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc (original)
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc Thu Dec 18 04:17:01 2014
@@ -715,8 +715,9 @@ bool ContainsSameAccess(u64 *s, u64 a, u
 #if defined(__SSE3__) && TSAN_SHADOW_COUNT == 4
   bool res = ContainsSameAccessFast(s, a, sync_epoch, is_write);
   // NOTE: this check can fail if the shadow is concurrently mutated
-  // by other threads.
-  DCHECK_EQ(res, ContainsSameAccessSlow(s, a, sync_epoch, is_write));
+  // by other threads. But it still can be useful if you modify
+  // ContainsSameAccessFast and want to ensure that it's not completely broken.
+  // DCHECK_EQ(res, ContainsSameAccessSlow(s, a, sync_epoch, is_write));
   return res;
 #else
   return ContainsSameAccessSlow(s, a, sync_epoch, is_write);





More information about the llvm-commits mailing list