[PATCH] Fix load-store optimizer on thumbv4t

Tim Northover t.p.northover at gmail.com
Wed Dec 17 11:54:25 PST 2014


So why couldn't you create a test? It doesn't seem like a terribly difficult issue to trigger: just a generic load/store merge operation on Thumb1.


================
Comment at: llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp:574
@@ +573,3 @@
+        if (isARMLowRegister(NewBase) && isARMLowRegister(Base) &&
+            Subtarget.isThumb1Only() && !Subtarget.hasV6Ops()) {
+          // thumbv4t doesn't have lo->lo copies that don't clobber cpsr,
----------------
Isn't the whole block already isThumb1?

http://reviews.llvm.org/D6592

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list