[PATCH] Prevent the creation of empty location list ranges.

Frederic Riss friss at apple.com
Tue Dec 16 11:50:41 PST 2014


- Reimplement in a more straightforward way.

So this commit doesn't pass the testsuite as a new test added last week by
Adrian would generate an empty range and thus be cleaned up by this patch.
I'm still posting it for reference. Another issue I noticed: the patch handles
locations the same way as the current logic does, using always the latest
started range. This makes no real sense as the instruction that makes us
close the range might be cloberring the register of any of the currently
opened ranges for the variables.

If you think it is still a good idea to apply something like that, just tell
me. Otherwise, I'm going to try to find some time to finally rewrite the pass
more in depth, because each time I touch it I realize a bit more how broken
it is.


http://reviews.llvm.org/D6497

Files:
  lib/CodeGen/AsmPrinter/DbgValueHistoryCalculator.cpp
  lib/CodeGen/AsmPrinter/DbgValueHistoryCalculator.h
  test/DebugInfo/X86/dbg-value-inlined-parameter.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6497.17350.patch
Type: text/x-patch
Size: 5180 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141216/9c003329/attachment.bin>


More information about the llvm-commits mailing list