[PATCH] [mips] Clean up the CodeGen/Mips/inlineasmmemop.ll test. NFC.

Toma Tabacu toma.tabacu at imgtec.com
Wed Dec 17 07:28:57 PST 2014


Hi dsanders,

Improve comments and remove a redundant attribute list.
There are no functional changes (to the CHECK's or to the code).

Part of these changes were suggested in http://reviews.llvm.org/D6637.

http://reviews.llvm.org/D6705

Files:
  test/CodeGen/Mips/inlineasmmemop.ll

Index: test/CodeGen/Mips/inlineasmmemop.ll
===================================================================
--- test/CodeGen/Mips/inlineasmmemop.ll
+++ test/CodeGen/Mips/inlineasmmemop.ll
@@ -24,42 +24,25 @@
 }
 
 ; CHECK-LABEL: main:
-; "D": Second word of double word. This works for any memory element
+; "D": Second word of a double word. This works for any memory element
 ; double or single.
 ; CHECK: #APP
 ; CHECK: lw ${{[0-9]+}},4(${{[0-9]+}});
 ; CHECK: #NO_APP
 
-; No "D": First word of double word. This works for any memory element 
+; No "D": First word of a double word. This works for any memory element
 ; double or single.
 ; CHECK: #APP
 ; CHECK: lw ${{[0-9]+}},0(${{[0-9]+}});
 ; CHECK: #NO_APP
 
-;int b[8] = {0,1,2,3,4,5,6,7};
-;int main()
-;{
-;  int i;
-; 
-;  // The first word. Notice, no 'D'
-;  { asm (
-;    "lw    %0,%1;\n"
-;    : "=r" (i) : "m" (*(b+4)));}
-; 
-;  // The second word
-;  { asm (
-;    "lw    %0,%D1;\n"
-;    : "=r" (i) "m" (*(b+4)));}
-;}
-
 @b = common global [20 x i32] zeroinitializer, align 4
 
 define void @main() {
 entry:
+; Second word:
   tail call void asm sideeffect "    lw    $0,${1:D};", "r,*m,~{$11}"(i32 undef, i32* getelementptr inbounds ([20 x i32]* @b, i32 0, i32 3))
+; First word. Notice, no 'D':
   tail call void asm sideeffect "    lw    $0,${1};", "r,*m,~{$11}"(i32 undef, i32* getelementptr inbounds ([20 x i32]* @b, i32 0, i32 3))
   ret void
 }
-
-attributes #0 = { nounwind }
-

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6705.17393.patch
Type: text/x-patch
Size: 1462 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141217/fb98d71a/attachment.bin>


More information about the llvm-commits mailing list