[PATCH] Fix suppressions file usage

[Filipe Cabecinhas]

I was mostly going for consistency, since other tests also overwrite the
files. I can revert that name change.

Want me to change the other tests too, so that they generate two files
instead of one + overwrite?

  Filipe

On Tue, Dec 16, 2014 at 7:31 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:
>
> ================
> Comment at: test/lsan/TestCases/suppressions_file.cc:7
> @@ -6,3 +6,3 @@
>
> -// RUN: echo "leak:%t" > %t.supp2
> -// RUN: LSAN_OPTIONS=$LSAN_BASE:suppressions="%t.supp2":symbolize=false
> %run %t
> +// RUN: echo "leak:%t" > %t.supp
> +// RUN: LSAN_OPTIONS=$LSAN_BASE:suppressions='%t.supp':symbolize=false
> %run %t
> ----------------
> Why would you need to change extension to .supp here? I think it's fine to
> have two different files in this test instead of overwriting a single file.
>
> http://reviews.llvm.org/D6680
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141217/6be842ca/attachment.html>