[PATCH] [Tablegen] Fix AsmString parser misreading optional operands.

Matthew Wahab matthew.wahab at arm.com
Tue Dec 16 08:50:54 PST 2014


> From: Tim Northover [mailto:t.p.northover at gmail.com]
> Sent: 16 December 2014 16:18
> 
> The changes look reasonable, but it'd be good to have some context on why
> you're doing it. Is this a prelude to enabling the Alias printing on ARM
> instead of using the custom code?

Thanks for reviewing the patch. 

It removes an obstacle to the ARM backend switching, which would probably be a
good thing but is rather more than I'm planning to do. The generic and custom
printers produce different outputs for some instructions and fixing that will
take some care. For now, this is just to fix a bug in the Tablegen output.

There's a second related patch for the Tablegen'd alias printer at
http://reviews.llvm.org/D6530, if you could take a look. I'm not sure whether
you worked on that part though.

Matthew

> REPOSITORY
>   rL LLVM
> 
> http://reviews.llvm.org/D6529
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/








More information about the llvm-commits mailing list