[PATCH] x86-32: PUSHF/POPF use/def EFLAGS

[JF Bastien]

Hi t.p.northover, jvoung,

As a side-quest for D6629 jvoung pointed out that I should use -verify-machineinstrs and this found a bug in x86-32's handling of EFLAGS for PUSHF/POPF. This patch fixes the use/def, and adds -verify-machineinstrs to all x86 tests which contain 'EFLAGS'. One exception: this patch leaves inline-asm-fpstack.ll as-is because it fails -verify-machineinstrs in a way unrelated to EFLAGS. This patch also modifies cmpxchg-clobber-flags.ll along the lines of what D6629 already does by also testing i386.

http://reviews.llvm.org/D6687

Files:
  lib/Target/X86/X86InstrInfo.td
  test/CodeGen/X86/2012-01-16-mfence-nosse-flags.ll
  test/CodeGen/X86/clobber-fi0.ll
  test/CodeGen/X86/cmov.ll
  test/CodeGen/X86/cmpxchg-clobber-flags.ll
  test/CodeGen/X86/coalescer-dce.ll
  test/CodeGen/X86/misched-copy.ll
  test/CodeGen/X86/misched-crash.ll
  test/CodeGen/X86/norex-subreg.ll
  test/CodeGen/X86/peep-test-2.ll
  test/CodeGen/X86/phys_subreg_coalesce-3.ll
  test/CodeGen/X86/pre-ra-sched.ll
  test/CodeGen/X86/remat-phys-dead.ll
  test/CodeGen/X86/sink-hoist.ll
  test/CodeGen/X86/vaargs.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6687.17347.patch
Type: text/x-patch
Size: 10358 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141216/ffc4a7a8/attachment.bin>