[PATCH] [Msan] Generalize instrumentation code to support FreeBSD mapping

Evgeniy Stepanov eugenis at google.com
Tue Dec 16 05:54:36 PST 2014


I like this approach.

FYI, there is a change that adds more platforms here: http://reviews.llvm.org/D6146.


================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:211
@@ +210,3 @@
+
+static const MemoryMapParams DefaultMemoryMapParams32 = {
+  0x000080000000,  // AndMask
----------------
I think we'd better call it "linux" instead of default, and mention "x86_64" somewhere, too.

http://reviews.llvm.org/D6666

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list