[PATCH] [inline-asm] Fix scope of assembly macros

Jim Grosbach grosbach at apple.com
Mon Dec 15 15:39:04 PST 2014


Use of assembler directives at all in inline assembly has always been an edge case that only sort-of works and is sketchily supported. The canonical answer to anyone having problems with them is "don't do that."

If we can improve the support for them with a small bit of effort, that seems reasonable to me, but if it's opening up even further the can of worms, I'd prefer a sternly worded diagnostic instead.

Use of .macro in function-level inline assembly is a pretty horrible thing. I don't mind at all saying that's completely unsupported. In module level assembly, it's a bit tougher question. If we're going to support the feature at all, the latter seems the right thing to work on.


http://reviews.llvm.org/D6383

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list