[PATCH] [MIPS64] Make __clear_cache more optimal

[Joerg Sonnenberger]

================
Comment at: lib/builtins/clear_cache.c:27
@@ +26,3 @@
+     */
+    void clear_mips_cache(const void* Addr, size_t Size);
+      asm(
----------------
Missing static to not pollute global namespace?

================
Comment at: lib/builtins/clear_cache.c:31
@@ +30,3 @@
+        ".align 2\n"
+        ".globl clear_mips_cache\n"
+        "clear_mips_cache:\n"
----------------
This should go away too. Why do you not use inline asm and let the compiler create the call and/or inline it? I'd prefer that...

http://reviews.llvm.org/D6661

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/