[PATCHES] R600/SI: VI fixes

Marek Olšák maraeo at gmail.com
Sun Dec 14 13:50:08 PST 2014


What should #3 test? I'm not sure how to test the bug that it fixes.
It was a bug in encoding, that's something llvm-lit isn't capable of
testing.

Marek

On Fri, Dec 12, 2014 at 11:57 PM, Matt Arsenault <arsenm2 at gmail.com> wrote:
>
>> On Dec 12, 2014, at 4:41 PM, Marek Olšák <maraeo at gmail.com> wrote:
>>
>> Please review.
>>
>> Marek
>
> #1 - Why can’t this use the same encoding mapping trick the other instructions do so everything except encoding doesn’t need to see separate opcodes?
>
> #2 LGTM
> #3 LGTM but needs a test
>
>
> -Matt




More information about the llvm-commits mailing list