[PATCH] Outline functions for SEH with the MSVC environment
Reid Kleckner
rnk at google.com
Fri Dec 12 15:50:16 PST 2014
Neat, so these tests pass? Seems like this approach is working! =D
The MSVCEHPrepare.cpp file has a bunch of Allman style braces, which should be fixed.
I feel like this is probably a good chunk of logic to commit, but we're a bit blocked on review. Long term, will need to do analysis to share regions of cleanup code in separate outlined functions rather than duplicating code.
REPOSITORY
rL LLVM
================
Comment at: lib/Transforms/Utils/CloneFunction.cpp:327
@@ +326,3 @@
+ = Director->handleInstruction(VMap, II, NewBB);
+ // If the stop handler says stop, we don't even want to stop everything,
+ // not just break out of the loop (which would cause the terminator to
----------------
This comment seems like it got mis-edited. :) Maybe "..., we want to stop everything. The cloning director is reponsible for inserting a terminator here."
================
Comment at: lib/Transforms/Utils/CloneFunction.cpp:383
@@ +382,3 @@
+ = Director->handleInstruction(VMap, OldTI, NewBB);
+ // If the stop handler says stop, we don't even want to stop everything,
+ // not just break out of the loop (which would cause the terminator to
----------------
ditto
http://reviews.llvm.org/D6556
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list