[PATCH] Insert tbb/tbh optimization where previous jump table resided

Tim Northover t.p.northover at gmail.com
Fri Dec 12 11:27:37 PST 2014


Hi Daniel,

The code change looks sensible, but I think the test could be made a bit clearer these days:


REPOSITORY
  rL LLVM

================
Comment at: test/CodeGen/Thumb2/constant-islands-jump-table.ll:45
@@ +44,3 @@
+  %d2 = phi i32 [%b1, %h1], [%a0, %h2]
+  %d3 = add i32 %d2, 8
+  %d4 = add i32 %d3, %d3
----------------
There's an @llvm.arm.space intrinsic now. It acts as an "instruction" of the precise size you specify. It's probably clearer and more efficient than putting in just the right number of real instructions.

http://reviews.llvm.org/D6621

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list