[PATCH] x86 NaCl: Emit LAHF/SAHF instead of PUSHF/POPF

JF Bastien jfb at chromium.org
Fri Dec 12 10:38:19 PST 2014


If you think it's useful I can make the code unconditional w.r.t. NaCl, and
make sahf/lahf the only thing generated here. I don't think performance is
a real argument here, though, since this code path shouldn't get exercised
often. If we really cared about performance then we wouldn't hit this path
in the first place!

On Fri, Dec 12, 2014 at 10:33 AM, Reid Kleckner <rnk at google.com> wrote:

> LLVM should never, ever generate popf from normal code. It's ridiculously
> slow. We should use sahf/lahf if we can.
>
>
> http://reviews.llvm.org/D6629
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141212/7f3e567d/attachment.html>


More information about the llvm-commits mailing list