[PATCH] Fix PR21807 - Minor code difference building with/without -g

Andrea Di Biagio andrea.dibiagio at gmail.com
Fri Dec 12 04:42:33 PST 2014


Hi Hal, Eric,
Thanks for the reviews.

Russ forgot to mention that he doesn't have commit access. So I
committed this on his behalf at revision 224118.

Thanks!
Andrea

On Fri, Dec 12, 2014 at 9:24 AM, Hal Finkel <hfinkel at anl.gov> wrote:
> ----- Original Message -----
>> From: "Eric Christopher" <echristo at gmail.com>
>> To: "Russell Gallop" <Russell_Gallop at sn.scee.net>, llvm-commits at cs.uiuc.edu, dblaikie at gmail.com, hfinkel at anl.gov
>> Sent: Thursday, December 11, 2014 1:19:26 PM
>> Subject: Re: [PATCH] Fix PR21807 - Minor code difference building with/without -g
>>
>> Seems reasonable to me.
>
> LGTM too.
>
>  -Hal
>
>>
>> -eric
>>
>>
>> On Thu Dec 11 2014 at 11:05:25 AM < Russell_Gallop at sn.scee.net >
>> wrote:
>>
>>
>> Hi,
>>
>> This patch fixes the issue reported as PR21807. There is a minor
>> difference in the generated code depending on the -g flag. This is a
>> non-functional difference.
>>
>> The cause seems to be that with -g the machine scheduler uses a
>> different scheduling strategy. This decision is based on the number
>> of instructions in a schedule region and includes debug instructions
>> in that count.
>>
>> This patch fixes the issue in MISched and provides a test.
>>
>> Regards
>> Russ
>>
>> Russell Gallop
>> SN Systems - Sony Computer Entertainment Group
>> http://www.snsys.com
>>
>>
>>
>>
>> **********************************************************************
>> This email and any files transmitted with it are confidential and
>> intended solely for the use of the individual or entity to whom they
>> are addressed. If you have received this email in error please
>> notify postmaster at scee.net
>> This footnote also confirms that this email message has been checked
>> for all known viruses.
>> Sony Computer Entertainment Europe Limited
>> Registered Office: 10 Great Marlborough Street, London W1F 7LP,
>> United Kingdom
>> Registered in England: 3277793
>> **********************************************************************
>>
>> P Please consider the environment before printing this e-mail
>> ______________________________ _________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/ mailman/listinfo/llvm-commits
>>
>
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list