[PATCH] Separate file parsing from File's constructors.

Simon Atanasyan simon at atanasyan.com
Thu Dec 11 20:56:54 PST 2014


LGTM


================
Comment at: include/lld/Core/File.h:159
@@ +158,3 @@
+  /// memory buffer passed to this file's constructor.
+  virtual std::error_code doParse() { return std::error_code(); }
+
----------------
Can we make this virtual method abstract?

http://reviews.llvm.org/D6633

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list