R600: Fix min/max matching problems with unordered compares

Tom Stellard tom at stellard.net
Thu Dec 11 18:01:58 PST 2014


On Thu, Dec 11, 2014 at 06:19:29PM -0500, Matt Arsenault wrote:
> 
> > On Nov 28, 2014, at 5:16 PM, Matt Arsenault <arsenm2 at gmail.com> wrote:
> > 
> > 
> >> On Nov 21, 2014, at 5:36 AM, Marek Olšák <maraeo at gmail.com> wrote:
> >> 
> >> Hi Matt,
> >> 
> >> I've just tested your patches. They don't fix the bug, but there might
> >> be nothing wrong with them, because I think the legacy opcodes
> >> themselves are the culprit and switching Mesa to use the mixnum/maxnum
> >> intrinsics fixes the issue too.
> >> 
> >> Marek
> >> 
> >> On Thu, Nov 20, 2014 at 12:27 AM, Matt Arsenault <arsenm2 at gmail.com> wrote:
> >>> These should fix https://bugs.freedesktop.org/show_bug.cgi?id=86432
> >>> 
> >>> 
> >>> 
> >>> 
> >>> _______________________________________________
> >>> llvm-commits mailing list
> >>> llvm-commits at cs.uiuc.edu
> >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >>> 
> > 
> > 
> > Here are updated patches which include removing isCommutable from the MachineInstrs
> > 
> > <0001-R600-SI-Don-t-promote-f32-select-to-i32.patch><0002-R600-SI-fmin-fmax_legacy-are-not-associative.patch><0003-R600-Fix-min-max-matching-problems-with-unordered-co.patch>
> 
> 
> Rebased
> 

LGTM.



> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list