[PATCH] DW_OP_const* is invalid as a location

[Eric Christopher]

Couple of comments inline, otherwise LGTM.

-eric


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1725
@@ -1724,1 +1724,3 @@
     }
+    // The proper way to describe a constant value is DW_OP_constu <const>, DW_OP_stack_value. 
+    // Unfortunately, DW_OP_stack_value was not available until DWARF-4, so we will continue to 
----------------
80-col?

================
Comment at: test/DebugInfo/incorrect-variable-debugloc1.ll:3
@@ +2,3 @@
+; This test is failing for powerpc64, because a location list for the
+; variable 'c' is not generated at all. Temporary making this test to XFAIL 
+; for powerpc, until PR21881 is fixed.
----------------
"Temporarily marking this test as XFAIL..."

================
Comment at: test/DebugInfo/incorrect-variable-debugloc1.ll:11
@@ +10,3 @@
+
+; This is a test for BZ #21176.
+; DW_OP_const <const> doesn't describe a constant value, but a value at a constant address. 
----------------
PR...

http://reviews.llvm.org/D6568

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/