[patch][lit] Make it compatible with python 3 (but drop python 2.5)

Justin Bogner mail at justinbogner.com
Thu Dec 11 10:02:16 PST 2014


So David Majnemer actually changed this from the "as" syntax to the ","
syntax in r223626 in order to keep our compatibility claim. I think we
need to make sure everyone's okay with upping our minimum python to 2.6
before we can commit this.

That said, I'm in favour of upping the minimum python as long as it
doesn't break anyone.

Dan Albert <danalbert at google.com> writes:
> LGTM unless anyone knows of a platform holding us to 2.5.
>
> On Thu, Dec 11, 2014 at 9:50 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com>
> wrote:
>
>     The attached patch makes the internal lit runner work on python 3, but
>     I am told it breaks compatibility with python 2.5.
>    
>     Is that OK. Is there some document that needs to be update to say we
>     need 2.6 now?
>    
>     Cheers,
>     Rafael




More information about the llvm-commits mailing list