[PATCH] Fix PR21694 - Revert improper use of divide in SCEV HowFarToZero computation

Mark Heffernan meheff at google.com
Wed Dec 10 14:54:54 PST 2014


r223974.

On Wed, Dec 10, 2014 at 12:51 PM, Mark Heffernan <meheff at google.com> wrote:
>
> On Wed, Dec 10, 2014 at 12:49 PM, David Majnemer <david.majnemer at gmail.com
> > wrote:
>>
>> Mark, I think we can just go ahead and commit this.  The change brings us
>> back to code which we already had and stops us from miscompiling.
>>
>
> Agreed.  Sorry I meant to submit this Monday, but some fires came up in my
> other work.  I'll submit it now.
>
> Mark
>
>
>>
>> On Fri, Dec 5, 2014 at 1:30 PM, Mark Heffernan <meheff at google.com> wrote:
>>
>>> Andrew, any comment on this?  This just reverts back to a previous more
>>> conservative (and correct) analysis.
>>>
>>> Mark
>>>
>>> On Thu, Dec 4, 2014 at 10:25 PM, David Majnemer <
>>> david.majnemer at gmail.com> wrote:
>>>>
>>>> LGTM
>>>>
>>>> http://reviews.llvm.org/D6546
>>>>
>>>>
>>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141210/a636cb1c/attachment.html>


More information about the llvm-commits mailing list