[llvm] r221915 - Object, Mach-O: Refactor and clean code up

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Dec 10 11:35:48 PST 2014


On 18 November 2014 at 21:04, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
>> -      assert(!DataInCodeLoadCmd && "Multiple data in code tables");
>> +      // Multiple data in code tables
>> +      if (DataInCodeLoadCmd) {
>> +        EC = object_error::parse_failed;
>> +        return;
>> +      }
>
> Do you have a testcase for this? As with COFF, an assert/unreachable
> is better unless we have a test showing how this is actually reached.

Ping.

I can revert this patch (revert attached) and check-all still passes.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 5396 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141210/0d98ccea/attachment.bin>


More information about the llvm-commits mailing list