[PATCH] Add per-test timeouts to lit

Jonathan Roelofs jonathan at codesourcery.com
Tue Dec 9 17:59:45 PST 2014


================
Comment at: utils/lit/lit/main.py:212
@@ -210,1 +211,3 @@
                      action="store", type=float, default=None)
+    group.add_option("", "--test-timeout", dest="testTimeout", metavar="N",
+                     help="Maximum time to spend in any given test (in seconds)",
----------------
ddunbar wrote:
> Can we just spell this "--timeout", it's pretty obvious. If you were worried about the conflict with --max-time I'd rather rename that one to --max-testing-time or something similar, as its not a commonly used option (and I wonder if anyone other than me ever uses it). :)
sounds good

================
Comment at: utils/lit/lit/util.py:156
@@ +155,3 @@
+
+    class Watchdog(object):
+        def __init__(self, popen, timeout):
----------------
thanks for the suggestion... I like this a lot more than what I had before.

http://reviews.llvm.org/D6584






More information about the llvm-commits mailing list