[llvm] r223802 - IR: Split Metadata from Value

[Duncan P. N. Exon Smith]

> On 2014 Dec 9, at 12:26, Hans Wennborg <hans at chromium.org> wrote:
> 
> On Tue, Dec 9, 2014 at 12:22 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> 
>> 
>> On Tue, Dec 9, 2014 at 12:07 PM, Hans Wennborg <hans at chromium.org> wrote:
>>> 
>>> This broke the MSVC build, see e.g. [1]. I suspect it is because MSVC
>>> (except recent versions) doesn't support LLVM_EXPORTED.
>> 
>> 
>> I take it you meant LLVM_EXPLICIT?
> 
> Yes; sorry, freudian slip :)
> 
>>> I tried
>>> removing those operator bool()'s, but there were more errors.
>>> 
>>> Does your patch compile if you remove LLVM_EXPORTED? I suspect that
>>> might reveal the same problem on Mac/Linux.
>>> 
>>> - Hans
>>> 
>>> 1.
>>> http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/660/steps/runhooks/logs/stdio
>> 
>> 
>> Somewhat surprised that compiles anywhere, really... Curious.
> 
> I'm working on a patch for appeasing MSVC which looks promising so far..

Does r223820 not fix it?