[llvm] r223755 - Revert "AsmParser: Reject invalid mismatch between forward ref and def"

[David Majnemer]

Author: majnemer
Date: Mon Dec  8 23:50:11 2014
New Revision: 223755

URL: http://llvm.org/viewvc/llvm-project?rev=223755&view=rev
Log:
Revert "AsmParser: Reject invalid mismatch between forward ref and def"

This reverts commit r223754.  I've upset the buildbots.

Removed:
    llvm/trunk/test/Assembler/invalid-fwdref2.ll
Modified:
    llvm/trunk/lib/AsmParser/LLParser.cpp

Modified: llvm/trunk/lib/AsmParser/LLParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLParser.cpp?rev=223755&r1=223754&r2=223755&view=diff
==============================================================================
--- llvm/trunk/lib/AsmParser/LLParser.cpp (original)
+++ llvm/trunk/lib/AsmParser/LLParser.cpp Mon Dec  8 23:50:11 2014
@@ -787,36 +787,33 @@ bool LLParser::ParseGlobal(const std::st
   if (Ty->isFunctionTy() || Ty->isLabelTy())
     return Error(TyLoc, "invalid type for global variable");
 
-  GlobalValue *GVal = nullptr;
+  GlobalVariable *GV = nullptr;
 
   // See if the global was forward referenced, if so, use the global.
   if (!Name.empty()) {
-    GVal = M->getNamedValue(Name);
-    if (GVal) {
+    if (GlobalValue *GVal = M->getNamedValue(Name)) {
       if (!ForwardRefVals.erase(Name) || !isa<GlobalValue>(GVal))
         return Error(NameLoc, "redefinition of global '@" + Name + "'");
+      GV = cast<GlobalVariable>(GVal);
     }
   } else {
     std::map<unsigned, std::pair<GlobalValue*, LocTy> >::iterator
       I = ForwardRefValIDs.find(NumberedVals.size());
     if (I != ForwardRefValIDs.end()) {
-      GVal = I->second.first;
+      GV = cast<GlobalVariable>(I->second.first);
       ForwardRefValIDs.erase(I);
     }
   }
 
-  GlobalVariable *GV;
   if (!GV) {
     GV = new GlobalVariable(*M, Ty, false, GlobalValue::ExternalLinkage, nullptr,
                             Name, nullptr, GlobalVariable::NotThreadLocal,
                             AddrSpace);
   } else {
-    if (GVal->getType()->getElementType() != Ty)
+    if (GV->getType()->getElementType() != Ty)
       return Error(TyLoc,
             "forward reference and definition of global have different types");
 
-    GV = cast<GlobalVariable>(GVal);
-
     // Move the forward-reference to the correct spot in the module.
     M->getGlobalList().splice(M->global_end(), M->getGlobalList(), GV);
   }

Removed: llvm/trunk/test/Assembler/invalid-fwdref2.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/invalid-fwdref2.ll?rev=223754&view=auto
==============================================================================
--- llvm/trunk/test/Assembler/invalid-fwdref2.ll (original)
+++ llvm/trunk/test/Assembler/invalid-fwdref2.ll (removed)
@@ -1,4 +0,0 @@
-; RUN: not llvm-as %s -disable-output 2>&1 | grep "forward reference and definition of global have different types"
-
- at a2 = alias void ()* @g2
- at g2 = internal global i8 42