[llvm] r223709 - [PowerPC]Activate FeatureVSX for the Power target

[Bill Schmidt]

On Mon, 2014-12-08 at 18:42 -0800, Filipe Cabecinhas wrote:
> But FeatureP8Vector disappeared. I just supposed that it was being
> used for testing, and got removed now and FeatureVSX got added to
> pwr8.
> Is the fix bringing it back (reverting half of the patch), or changing
> the target to something other than power8-vector?

It looks like the patch that was committed wasn't the one that was
reviewed, so some mishap occurred.  I'm working on repairing it now.  We
should keep the P8Vector feature...

Bill
> 
> 
> Thanks,
> 
> 
>   Filipe
> 
> 
> P.S: I'll just wait for the patch, but got curious.
> 
> 
> 
>   F
> 
> 
> On Mon, Dec 8, 2014 at 6:15 PM, Bill Schmidt
> <wschmidt at linux.vnet.ibm.com> wrote:
>         On Mon, 2014-12-08 at 15:40 -0800, Filipe Cabecinhas wrote:
>         > Can you fix the tests too, please?
>         > CodeGen/PowerPC/vsx-p8.ll started failing because it was
>         using
>         > power8-vector.
>         >
>         Ah, this would be fixed by adding FeatureP8Vector to Power8,
>         which we
>         should probably do ASAP.  Bill, can you look into that
>         tomorrow?
>         
>         Thanks,
>         Bill
>         >
>         >
>         > Thanks,
>         >
>         >
>         >   Filipe
>         >
>         >   F
>         >
>         >
>         > On Mon, Dec 8, 2014 at 3:07 PM, Bill Seurer
>         > <seurer at linux.vnet.ibm.com> wrote:
>         >         Author: seurer
>         >         Date: Mon Dec  8 17:07:12 2014
>         >         New Revision: 223709
>         >
>         >         URL:
>         http://llvm.org/viewvc/llvm-project?rev=223709&view=rev
>         >         Log:
>         >         [PowerPC]Activate FeatureVSX for the Power target
>         >
>         >         This change activates FeatureVSX for Power 7 and
>         Power 8 in
>         >         PPC.td.
>         >
>         >         http://reviews.llvm.org/D6570
>         >
>         >         Modified:
>         >             llvm/trunk/lib/Target/PowerPC/PPC.td
>         >
>         >         Modified: llvm/trunk/lib/Target/PowerPC/PPC.td
>         >         URL:
>         >
>          http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPC.td?rev=223709&r1=223708&r2=223709&view=diff
>         >
>          ==============================================================================
>         >         --- llvm/trunk/lib/Target/PowerPC/PPC.td (original)
>         >         +++ llvm/trunk/lib/Target/PowerPC/PPC.td Mon Dec  8
>         17:07:12
>         >         2014
>         >         @@ -104,9 +104,6 @@ def FeatureQPX       :
>         SubtargetFeature<
>         >          def FeatureVSX       :
>         SubtargetFeature<"vsx","HasVSX",
>         >         "true",
>         >                                                  "Enable VSX
>         >         instructions",
>         >
>         [FeatureAltivec]>;
>         >         -def FeatureP8Vector  :
>         SubtargetFeature<"power8-vector",
>         >         "HasP8Vector", "true",
>         >         -                                        "Enable
>         POWER8 vector
>         >         instructions",
>         >         -
>         [FeatureVSX,
>         >         FeatureAltivec]>;
>         >
>         >          def DeprecatedMFTB   : SubtargetFeature<"",
>         "DeprecatedMFTB",
>         >         "true",
>         >                                                  "Treat mftb
>         as
>         >         deprecated">;
>         >         @@ -119,6 +116,7 @@ def DeprecatedDST    :
>         SubtargetFeature<
>         >          // CMPB         p6, p6x, p7        cmpb
>         >          // DFP          p6, p6x, p7        decimal
>         floating-point
>         >         instructions
>         >          // POPCNTB      p5 through p7      popcntb and
>         related
>         >         instructions
>         >         +// VSX          p7                 vector-scalar
>         instruction
>         >         set
>         >
>         >
>           //===----------------------------------------------------------------------===//
>         >          // ABI Selection
>         >                           //
>         >         @@ -303,7 +301,7 @@ def : ProcessorModel<"pwr6x",
>         G5Model,
>         >                             FeatureFPRND, Feature64Bit,
>         >                             DeprecatedMFTB, DeprecatedDST]>;
>         >          def : ProcessorModel<"pwr7", P7Model,
>         >         -                  [DirectivePwr7, FeatureAltivec,
>         >         +                  [DirectivePwr7, FeatureAltivec,
>         FeatureVSX,
>         >                             FeatureMFOCRF, FeatureFCPSGN,
>         >         FeatureFSqrt, FeatureFRE,
>         >                             FeatureFRES, FeatureFRSQRTE,
>         >         FeatureFRSQRTES,
>         >                             FeatureRecipPrec, FeatureSTFIWX,
>         >         FeatureLFIWAX,
>         >         @@ -312,7 +310,7 @@ def : ProcessorModel<"pwr7",
>         P7Model,
>         >                             Feature64Bit /*,
>         Feature64BitRegs */,
>         >                             DeprecatedMFTB, DeprecatedDST]>;
>         >          def : ProcessorModel<"pwr8", P7Model /* FIXME:
>         Update to
>         >         P8Model when available */,
>         >         -                  [DirectivePwr8, FeatureAltivec,
>         >         +                  [DirectivePwr8, FeatureAltivec,
>         FeatureVSX,
>         >                             FeatureMFOCRF, FeatureFCPSGN,
>         >         FeatureFSqrt, FeatureFRE,
>         >                             FeatureFRES, FeatureFRSQRTE,
>         >         FeatureFRSQRTES,
>         >                             FeatureRecipPrec, FeatureSTFIWX,
>         >         FeatureLFIWAX,
>         >
>         >
>         >         _______________________________________________
>         >         llvm-commits mailing list
>         >         llvm-commits at cs.uiuc.edu
>         >
>          http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>         >
>         >
>         > _______________________________________________
>         > llvm-commits mailing list
>         > llvm-commits at cs.uiuc.edu
>         > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>         
>         
>         
> 
>