[PATCH] DW_OP_const* is invalid as a location

[David Blaikie]

================
Comment at: test/DebugInfo/incorrect-variable-debugloc1.ll:14
@@ +13,3 @@
+; 
+; int main()
+; {
----------------
kromanova wrote:
> kromanova wrote:
> > dblaikie wrote:
> > > Can this example be simplified further? (do we need the loop, etc?)
> > I will simplify the test as much as I can. 
> > BTW, thank you David for reviewing the patch so quickly!
> Is there an elegant solution to test different Dwarf versions (Dwarf-2, Dwarf-3 and Dwarf-4) using .ll file, while avoiding creation of multiple copies of the same test with only one line difference in metadata representing Dwarf Version. 
> 
> !12 = metadata !{i32 2, metadata !"Dwarf Version", i32 4}  // needed for dwarf-4 test
> !12 = metadata !{i32 2, metadata !"Dwarf Version", i32 2}  // needed for dwarf-2 test
> 
> Or should I create a .cpp test instead of .ll test to avoid duplication of the test?
> 
Yep - check the other test cases that have "-dwarf-version" in the llc command line.

http://reviews.llvm.org/D6568