[PATCH] zorg: jenkins: Rewrite 'derive' to be more flexible
Chris Matthews
chris.matthews at apple.com
Mon Dec 8 13:44:15 PST 2014
Thanks. I committed with some little fixups.
> On Dec 6, 2014, at 10:44 AM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>
> This patch series adds a `derive-llvm+clang` command to the
> Jenkins build.py.
>
> - 0001: Refactor `derive()` and `derive_lldb()` to share
> code and stop hardcoding expectations. Although the
> exact rsync commands will change slightly (with some
> redundant excludes), there should be no effective
> functionality change.
>
> @Sean: you might want to check the `lldb`-related logic.
> If you want I can leave `derive_lldb()` just as I found
> it; maybe it's not valuable to share code there.
>
> - 0002: Change `check_repo_state()` to log what it finds
> instead of giving an error when something is missing.
>
> IMO, the sanity check only provides value on builders
> that aren't mature. Builders that are "working" should
> fail in the "acquire" step. Logging what's going on
> seems sufficient.
>
> Another approach would be to thread the set of repos
> through the `build()` step, but I think that would be
> pretty awkward.
>
> - 0003: Add `derive-llvm+clang()`.
>
> The end goal is to enable Jenkins to checkout just llvm and
> clang for a faster incremental builder.
>
> (I didn't find any tests... did I miss them somewhere?)
>
> <0001-jenkins-Factor-out-hard-coded-logic-NFC.patch><0002-jenkins-Loosen-restriction-on-checked-out-repos.patch><0003-jenkins-Add-derive-llvm-clang.patch>
More information about the llvm-commits
mailing list