[PATCH] AVX-512 Intrinsics for ER instructions

Adam Nemet anemet at apple.com
Mon Dec 8 10:17:23 PST 2014


================
Comment at: lib/Target/X86/X86InstrAVX512.td:5
@@ -4,2 +4,3 @@
 // individual arguments.
+// The template is also used for scalar types, in this case numelts is 1.
 class X86VectorVTInfo<int numelts, ValueType EltVT, RegisterClass rc,
----------------
Please also mention that for scalar types we map them to the smallest (128-bit) vector type with  the same element type.  And the motivation: so that masking logic can be transferred to them.

LGTM with something like that.

http://reviews.llvm.org/D6214






More information about the llvm-commits mailing list