[PATCH] [X86] Convert esp-relative movs of function arguments to pushes, step 1

[Kuperstein, Michael M]

As expected, no performance change.

Any other issues (there's actually a small style violation in the review, will fix before committing) ?

From: Nadav Rotem [mailto:nrotem at apple.com]
Sent: Wednesday, December 03, 2014 23:54
To: reviews+D6503+public+b702a7f66de6a943 at reviews.llvm.org
Cc: Kuperstein, Michael M; Demikhovsky, Elena; eliben at google.com; llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] [X86] Convert esp-relative movs of function arguments to pushes, step 1


On Dec 3, 2014, at 1:45 PM, Michael Kuperstein <michael.m.kuperstein at intel.com<mailto:michael.m.kuperstein at intel.com>> wrote:

2) I don't really expect a performance change, in either direction - this step is mostly for code size.

Reducing code size could improve performance by reducing instruction cache pressure. :)

LGTM.
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141208/3bc32945/attachment.html>