[PATCH] Compiler-rt changes for dynamic-alloca-for-stack-variables change.

Kostya Serebryany kcc at google.com
Fri Dec 5 16:41:37 PST 2014


Code LGTM, but let me see the LLVM part in more detail...

================
Comment at: lib/asan/asan_fake_stack.cc:199
@@ -198,4 +198,3 @@
   FakeFrame *ff = fs->Allocate(fs->stack_size_log(), class_id, real_stack);
-  if (!ff)
-    return real_stack;  // Out of fake stack, return the real one.
+  if (!ff) return 0;  // Out of fake stack, return the real one.
   uptr ptr = reinterpret_cast<uptr>(ff);
----------------
Update comment?

http://reviews.llvm.org/D6545






More information about the llvm-commits mailing list