[PATCH] [mips] [test] Enable COMPILER_RT_INCLUDE_TESTS for MIPS

Alexey Samsonov vonosmas at gmail.com
Fri Dec 5 12:08:49 PST 2014


================
Comment at: lib/sanitizer_common/tests/sanitizer_allocator_test.cc:384
@@ -381,3 +383,3 @@
   // Test alignments.
-  uptr max_alignment = SANITIZER_WORDSIZE == 64 ? (1 << 28) : (1 << 24);
+  uptr max_alignment = SANITIZER_CAN_USE_ALLOCATOR64 ? (1 << 28) : (1 << 24);
   for (uptr alignment = 8; alignment <= max_alignment; alignment *= 2) {
----------------
Why do you need this change? This test case seems to test LargeMmapAllocator, not SizeClassAllocator64.

================
Comment at: lib/sanitizer_common/tests/sanitizer_printf_test.cc:34
@@ +33,3 @@
+  strcpy(expectedString, "a-1b-2c4294967292e5fahbq0x");
+  memset(expectedString + 26, '0', SANITIZER_POINTER_FORMAT_LENGTH - 3);
+  strcpy(expectedString + 23 + SANITIZER_POINTER_FORMAT_LENGTH,
----------------
OMG, please no "+26". Just use `std::string` here.

http://reviews.llvm.org/D6461






More information about the llvm-commits mailing list