[compiler-rt] r223477 - [ASan] Fix Win build following r223419.
Sergey Matveev
earthdok at google.com
Fri Dec 5 08:53:58 PST 2014
Author: smatveev
Date: Fri Dec 5 10:53:58 2014
New Revision: 223477
URL: http://llvm.org/viewvc/llvm-project?rev=223477&view=rev
Log:
[ASan] Fix Win build following r223419.
Modified:
compiler-rt/trunk/lib/asan/asan_interceptors.cc
Modified: compiler-rt/trunk/lib/asan/asan_interceptors.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_interceptors.cc?rev=223477&r1=223476&r2=223477&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/asan_interceptors.cc (original)
+++ compiler-rt/trunk/lib/asan/asan_interceptors.cc Fri Dec 5 10:53:58 2014
@@ -731,13 +731,25 @@ INTERCEPTOR_WINAPI(DWORD, CreateThread,
if (flags()->strict_init_order)
StopInitOrderChecking();
GET_STACK_TRACE_THREAD;
- u32 current_tid = GetCurrentTidOrInvalid();
- AsanThread *t = AsanThread::Create(start_routine, arg);
- CreateThreadContextArgs args = { t, &stack };
bool detached = false; // FIXME: how can we determine it on Windows?
- asanThreadRegistry().CreateThread(*(uptr*)t, detached, current_tid, &args);
- return REAL(CreateThread)(security, stack_size,
- asan_thread_start, t, thr_flags, tid);
+ ThreadStartParam param;
+ atomic_store(¶m.t, 0, memory_order_relaxed);
+ atomic_store(¶m.is_registered, 0, memory_order_relaxed);
+ DWORD result = REAL(CreateThread)(security, stack_size, asan_thread_start,
+ ¶m, thr_flags, tid);
+ if (result) {
+ u32 current_tid = GetCurrentTidOrInvalid();
+ AsanThread *t = AsanThread::Create(start_routine, arg);
+ CreateThreadContextArgs args = { t, &stack };
+ asanThreadRegistry().CreateThread(*reinterpret_cast<uptr *>(t), detached,
+ current_tid, &args);
+ atomic_store(¶m.t, reinterpret_cast<uptr>(t), memory_order_release);
+ // The pthread_create interceptor waits here, so we do the same for
+ // consistency.
+ while (atomic_load(¶m.is_registered, memory_order_acquire) == 0)
+ internal_sched_yield();
+ }
+ return result;
}
namespace __asan {
More information about the llvm-commits
mailing list