[llvm] r221960 - IR: Rewrite uniquing and creation of MDString

[Duncan P. N. Exon Smith]

> On 2014-Dec-04, at 17:10, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
>> On 2014-Dec-04, at 15:44, Alexey Samsonov <vonosmas at gmail.com> wrote:
>> 
>> FYI, StringMapEntry<>::GetStringMapEntryFromValue is inherently broken - I've failed to fix it in r223402, but failed. We can't just "get the offset" of a non-standard-layout object field.
> 
> Crap.
> 
>> I'd be happy to delete GetStringMapEntryFromValue from the codebase completely, but currently MDString::getString() is its only user.
>> 
> 
> I'll remove that use, and kill the function myself.  Thanks.

r223438 and r223439.  Sorry I missed the bot failure (if there was one).