[PATCH] [lld] ELF: Use ELF reloc .def files to reduce duplication

[Shankar Easwaran]

LGTM for lld.

On 12/4/2014 4:02 AM, Will Newton wrote:
> On 26 November 2014 at 02:01, Sean Silva <chisophugis at gmail.com> wrote:
>> Hmm.
>> Adding Michael.
>>
>> Michael, does this patch make sense, or can we deduplicate this
>> string->number table better?
> Ping. The only other places this mapping is done are ELFYAML and
> lib/Object/ELF.cpp which both encode it as a switch rather than a data
> table so would involve a bit of effort to refactor into the same
> shape.
>
>> On Tue, Nov 25, 2014 at 1:35 AM, Will Newton <will.newton at linaro.org> wrote:
>>> On 25 November 2014 at 02:35, Sean Silva <chisophugis at gmail.com> wrote:
>>>
>>> Hi Sean,
>>>
>>>> Surely we must have such tables floating around somewhere already?
>>> Possibly, although I am not familiar enough with the codebase to say
>>> for sure. The LLD KindString tables may be slightly different in that
>>> they have a terminator at the end and they also contain some values
>>> that are LLD internal and not real relocation numbers e.g. see the
>>> MIPS port with various LLD_R_MIPS_* constants.
>>>
>>>> On Mon, Nov 24, 2014 at 3:55 AM, Will Newton <will.newton at linaro.org>
>>>> wrote:
>>>>> This patch uses the recently added ELF reloc .def files to reduce
>>>>> duplication of reloc names in LLD.
>>>>>
>>>>> --
>>>>> Will Newton
>>>>> Toolchain Working Group, Linaro
>>>>>
>>>>> _______________________________________________
>>>>> llvm-commits mailing list
>>>>> llvm-commits at cs.uiuc.edu
>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>>
>>>
>>>
>>> --
>>> Will Newton
>>> Toolchain Working Group, Linaro
>>
>
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation