[PATCH] [ASan] Refactor thread starting code.
Alexey Samsonov
vonosmas at gmail.com
Thu Dec 4 17:16:48 PST 2014
LGTM. Thanks!
================
Comment at: lib/asan/asan_interceptors.cc:201
@@ -200,3 @@
- AsanThread *t = AsanThread::Create(start_routine, arg);
- CreateThreadContextArgs args = { t, &stack };
- asanThreadRegistry().CreateThread(*reinterpret_cast<uptr *>(t), detached,
----------------
Can we remove CreateThreadContextArgs from asan_thread.h header now?
================
Comment at: lib/asan/asan_interceptors.cc:735
@@ -739,1 +734,3 @@
+ AsanThread *t =
+ AsanThread::Create(start_routine, arg, current_tid, stack, detached);
return REAL(CreateThread)(security, stack_size,
----------------
s/stack/&stack
http://reviews.llvm.org/D6544
More information about the llvm-commits
mailing list