[PATCH] [compiler-rt] Implement AddressSanitizer suppressions

Sergey Matveev earthdok at google.com
Thu Dec 4 17:09:15 PST 2014


================
Comment at: lib/sanitizer_common/sanitizer_suppressions.cc:27
@@ -27,1 +26,3 @@
+    "deadlock", "vptr_check", "interceptor_name", "interceptor_via_function",
+    "interceptor_via_library"};
 
----------------
kubabrecka wrote:
> earthdok wrote:
> > My $.02: we have "called_from_lib" and "interceptor_via_library". We also have "interceptor_via_function" here and "fun" in the blacklist syntax. Maybe use "lib" and "fun" everywhere for consistency?
> I don't necessarily disagree, but I'd like to point out that they work differently:
> * interceptor_via_library ... suppresses interceptors only and matches library anywhere on the stack
> * interceptor_via_function ... suppresses interceptors only and matches a function name anywhere on the stack
> * called_from_lib ... also interceptors only, but only checks the topmost frame on the stack
> 
> Also, we should keep the "interceptor" in the name to indicate that these suppressions work only on interceptors, and not instrumented code (other suppression types work even on instrumented code).
Sorry, I could have been clearer. I suggest to name them "interceptor_via_lib" and "interceptor_via_fun" (not simply "lib" and "fun").

http://reviews.llvm.org/D6280






More information about the llvm-commits mailing list