[PATCH] [compiler-rt] Implement AddressSanitizer suppressions

Kuba Brecka kuba.brecka at gmail.com
Thu Dec 4 16:16:53 PST 2014


Addressing review comments.

> > // Check that reports from instrumented code cannot be suppressed.
> Wait, how do you enforce that? By assuming that memset() in user code will be
> turned into __asan_memset() call? In fact, I see little harm in suppressing
> reports from memset() from instrumented code if the user explicitly added
> interceptor_name:memset to suppression file. After all, this would work for
> another interceptors (like strcpy), won't it?

I meant memset/memcpy/memmove only. Since these can easily be inlined, the suppression will not work reliably on them, and so it sounds like a good idea to just disallow suppressions for these functions (when used from instrumented code).

http://reviews.llvm.org/D6280

Files:
  lib/asan/CMakeLists.txt
  lib/asan/asan_interceptors.cc
  lib/asan/asan_rtl.cc
  lib/asan/asan_suppressions.cc
  lib/asan/asan_suppressions.h
  lib/sanitizer_common/sanitizer_suppressions.cc
  lib/sanitizer_common/sanitizer_suppressions.h
  lib/sanitizer_common/tests/sanitizer_suppressions_test.cc
  test/asan/TestCases/Darwin/suppressions-darwin.cc
  test/asan/TestCases/suppressions-function.cc
  test/asan/TestCases/suppressions-instrumented-code.cc
  test/asan/TestCases/suppressions-interceptor.cc
  test/asan/TestCases/suppressions-library.cc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6280.16964.patch
Type: text/x-patch
Size: 33781 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141205/4c05f1b7/attachment.bin>


More information about the llvm-commits mailing list