[PATCH] [GraphWriter] Attempt to open .dot files with xdg-open/open first

Matthias Braun matze at braunis.de
Thu Dec 4 11:00:27 PST 2014


Hi chandlerc,

Most desktop environments let the users specify his preferred application per
file type. On mac/linux we can use open/xdg-open for that and should try this
first before starting a heuristic search for various programs.

I hope this is not going to be too much of a bikesched discussion, but I really
prefer it when I can configure the applications myself instead of having a
hardcoded default list, though after seeing r210148 which tries 'gv' before
'xdg-open' I wonder if there is a problem with that approach for some people?
Can you explain why you did this alp? Couldn't people just set their system to open all postscript files gv?

http://reviews.llvm.org/D6534

Files:
  lib/Support/GraphWriter.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6534.16939.patch
Type: text/x-patch
Size: 1085 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141204/05a3be1f/attachment.bin>


More information about the llvm-commits mailing list