[llvm] r223137 - [Statepoints 3/4] Statepoint infrastructure for garbage collection: SelectionDAGBuilder

[Philip Reames]

On 12/04/2014 09:16 AM, Philip Reames wrote:
>
> On 12/04/2014 09:08 AM, Philip Reames wrote:
>>
>> On 12/04/2014 08:38 AM, Joerg Sonnenberger wrote:
>>> On Tue, Dec 02, 2014 at 06:50:36PM -0000, Philip Reames wrote:
>>>> Author: reames
>>>> Date: Tue Dec  2 12:50:36 2014
>>>> New Revision: 223137
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=223137&view=rev
>>>> Log:
>>>> [Statepoints 3/4] Statepoint infrastructure for garbage collection: 
>>>> SelectionDAGBuilder
>>> This crashes on the attached input, build with -O2.
>> Looking into this now.  I'm very surprised by this, there's nothing 
>> in this patch which should trigger for code which doesn't contain 
>> statepoints.
> I spotted a typo that might be causing this.  There was a cast used in 
> place of what was intended to by a dyn_cast test when checking to see 
> if an Instruction was a CallInst.  I'm still building Clang to be able 
> to replicate your actual example, but I'm going to submit a premptive 
> change in the hope it fixes your crash.
I submitted the typo fix in 223370.  I'm still waiting for my Clang 
build to complete with a TOT checkout to see if I can reproduce your 
exact issue.  Looking at the test case, I suspect this is the problem 
since I added a check in the handling of type casts for varargs calls 
which would have exercised the problematic path.
>>
>>>
>>> Joerg
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits