[PATCH] [DFSAN][MIPS][LLVM] Defining ShadowPtrMask variable for MIPS64

Peter Collingbourne peter at pcc.me.uk
Wed Dec 3 11:26:53 PST 2014


================
Comment at: lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:438
@@ -430,1 +437,3 @@
+  else if (IsMIPS64)
+    ShadowPtrMask = ConstantInt::getSigned(IntptrTy, ~0xF000000000LL);
 
----------------
kumarsukhani wrote:
> pcc wrote:
> > This should do something sensible if the target is unsupported, maybe call `report_fatal_error`?
> @pcc: clang does that for us[1], should I still add the call to report_fatal_error?
> 
> [1] http://reviews.llvm.org/D6147
Yes, the pass could be used from `opt` or other frontends and it shouldn't crash in those cases.

http://reviews.llvm.org/D6459






More information about the llvm-commits mailing list