[PATCH] [mips] [test] Enable COMPILER_RT_INCLUDE_TESTS for MIPS

Alexey Samsonov vonosmas at gmail.com
Tue Dec 2 12:07:14 PST 2014


================
Comment at: lib/sanitizer_common/tests/CMakeLists.txt:5
@@ -4,1 +4,3 @@
 
+filter_available_targets(SANITIZER_TEST_SUPPORTED_ARCH x86_64 i386 mips64 mips64el)
+
----------------
Let's name it as SANITIZER_UNITTEST_SUPPORTED_ARCH.

Also, please add a FIXME to just use SANITIZER_COMMON_SUPPORTED_ARCH here.

================
Comment at: lib/sanitizer_common/tests/sanitizer_allocator_test.cc:32
@@ -31,3 +31,3 @@
 
-#if SANITIZER_WORDSIZE == 64
+#if SANITIZER_CAN_USE_ALLOCATOR64 == 64
 static const uptr kAllocatorSpace = 0x700000000000ULL;
----------------
This line makes no sense - probably you've meant
  #if SANITIZER_CAN_USE_ALLOCATOR64
?

================
Comment at: lib/sanitizer_common/tests/sanitizer_printf_test.cc:37
@@ -35,2 +36,3 @@
+                 "0x0000000123e_string_r", buf);
   } else {
     EXPECT_STREQ("a-1b-2c4294967292e5fahbq"
----------------
I'd prefer to build the expected string for arbitrary value of SANITIZER_POINTER_FORMAT_LENGTH instead.

http://reviews.llvm.org/D6461






More information about the llvm-commits mailing list