[PATCH]: finish .cpu support for ARM

Roman Divacky rdivacky at vlakno.cz
Tue Dec 2 11:18:14 PST 2014


Like this?

On Tue, Dec 02, 2014 at 10:53:44AM -0800, Tim Northover wrote:
> > Sure... with a fixed test case now.
> 
> Sorry to do this (I should have looked harder the first time), but it
> still seems a little lax. The ".cpu cortex-a8" could fail and we'd
> never notice. I'd probably suggest separating stdout and stderr (%t
> and %t2 are temporary files that llvm-lit understands).
> 
> You can check that stdout does contain the valid .cpu directive and
> the dsb instruction (only once!), and that stderr has the errors
> you're already looking for.
> 
> I'd suggest separate files because mixing them with "2>&1" tends to be
> OK if you're only checking one, but can lead to race conditions if
> you're interested in both.
> 
> Cheers.
> 
> Tim.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm.cpu.patch
Type: text/x-diff
Size: 2042 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141202/bb6202dd/attachment.patch>


More information about the llvm-commits mailing list